From 21cc43fe6b22dbdb0c93324295e774cb3cbb8c91 Mon Sep 17 00:00:00 2001 From: rasul Date: Wed, 25 Nov 2020 20:48:13 -0600 Subject: [PATCH] only try to get ip address if necessary --- he-ddns | 32 ++++++++++++++++++-------------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/he-ddns b/he-ddns index bb1b2b4..6ac9120 100755 --- a/he-ddns +++ b/he-ddns @@ -50,18 +50,22 @@ done # shellcheck source=he-ddnsrc . "$config" || die $LINENO -ipv4="$(curl -sSL4 "$ip_host")" || die $LINENO -for domain in "${!DOMAINS4[@]}"; do - printf "%s :: " "$domain" - key=${DOMAINS4[$domain]} - curl -sSL4 "$url" -d "hostname=$domain" -d "password=$key" -d "myip=$ipv4" || die $LINENO - echo -done +if [[ -n "${DOMAINS4[*]}" ]]; then + ipv4="$(curl -sSL4 "$ip_host")" || die $LINENO + for domain in "${!DOMAINS4[@]}"; do + printf "%s :: " "$domain" + key=${DOMAINS4[$domain]} + curl -sSL4 "$url" -d "hostname=$domain" -d "password=$key" -d "myip=$ipv4" || die $LINENO + echo + done +fi -ipv6="$(curl -sSL6 "$ip_host")" || die $LINENO -for domain in "${!DOMAINS6[@]}"; do - printf "%s :: " "$domain" - key=${DOMAINS6[$domain]} - curl -sSL6 "$url" -d "hostname=$domain" -d "password=$key" -d "myip=$ipv6" || die $LINENO - echo -done +if [[ -n "${DOMAINS6[*]}" ]]; then + ipv6="$(curl -sSL6 "$ip_host")" || die $LINENO + for domain in "${!DOMAINS6[@]}"; do + printf "%s :: " "$domain" + key=${DOMAINS6[$domain]} + curl -sSL6 "$url" -d "hostname=$domain" -d "password=$key" -d "myip=$ipv6" || die $LINENO + echo + done +fi